[Map] return bounding box for static feature collection without joins #66607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
release_note:fix
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
There was a problem hiding this comment.
Thx for the fix and the small refactor to add the test.
There's an edge-case that still breaks:
Layers with term-joins that are not backed by EMS, but by ES-doc layers.
e.g.
- download world-countries from https://maps.elastic.co/#file/world_countries
- upload with GeoJson uploader in Maps
- add layer: turn apply-global-filter switch off
- add term-join with sample-logs on
iso2=geo.dest
=> fit2bounds will always navigate to entire layer iso only to the countries that have a matching join
I think the fix would be that if a layer has joins, it always should check against the visibility of features in the source-feature-collection and not delegate to Source#getBoundsForFilters. Am I missing something?
should be refined then to also check if the layer has joins.
Thoughts on adding it to this PR (?)
thomasneirynck
approved these changes
May 14, 2020
There was a problem hiding this comment.
discussed with @nreese
will use new PR for edge-case when layer is an ES-doc layer
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
May 15, 2020
…elastic#66607) * [Map] return bounding box for static feature collection without joins * tslint Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
nreese
added a commit
to nreese/kibana
that referenced
this pull request
May 15, 2020
…elastic#66607) * [Map] return bounding box for static feature collection without joins * tslint Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/maps/public/classes/layers/vector_layer/vector_layer.js
This was referenced May 15, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 15, 2020
* master: (191 commits) [Maps] Get number of categories from palette (elastic#66454) move oss features registration to KP (elastic#66524) [kbn/plugin-helpers] typescript-ify (elastic#66513) Add kibana-operations as codeowners for .ci/es-snapshots and vars/ (elastic#66746) FTR: move basic services under common folder (elastic#66563) Migrate Beats Management UI to KP (elastic#65791) [CI] Add 20 minutes to overall build timeout lint import from restricted zones for export exressions (elastic#66588) [SIEM][Detection Engine] Add validation for Rule Actions (elastic#63332) KP plugins shouldn't need package.json (elastic#66654) Replace agent metrics link with the new one (elastic#66632) [CI] Add one retry to setup step (elastic#66638) [CI] Add slack alerts to tracked branch jobs, change default channel, change formatting (elastic#66580) [docLinks] Add docLinks to CoreSetup. (elastic#66631) [DOCS] Rename monitoring collection from internal to legacy (elastic#65781) unskip newsfeed tests (elastic#66562) [NP] Migrate uiSettings owned by Kibana app (elastic#64321) [ML] Functional tests - stabilize typing in DFA mml input (elastic#66706) [Map] return bounding box for static feature collection without joins (elastic#66607) remove trailing slash in graph sample data links (elastic#66358) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #66582